Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AnswersClient): V1 implementation #528

Open
wants to merge 5 commits into
base: v3
Choose a base branch
from
Open

feat(AnswersClient): V1 implementation #528

wants to merge 5 commits into from
+167 −0

Conversation

PLNech
Copy link
Member

@PLNech PLNech commented Jun 4, 2021 •
edited
Loading

Q A
New feature? yes/no
Need Doc update yes

Describe your change

Adds a first implementation of the Answers API's prediction endpoint.

Design considerations

  • As the API is still in beta, this implem doesn't strongly type Answers parameters like query, queryLanguages, or returnExtractAttribute until these have a finalized status and naming.
  • I made the index a parameter, to allow for the same AnswersClient to target different indices successively - can be reconsidered if it makes it inconsistent with this client's users' expectations.

@PLNech PLNech requested a review from TomKlotzPro June 4, 2021 15:29
TomKlotzPro
TomKlotzPro suggested changes Jun 16, 2021
View reviewed changes
Copy link

@TomKlotzPro TomKlotzPro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice Job @PLNech !!! Really like your python, I've request few minors changes related to our format standard. Overall really nice :)

tests/features/test_answers_client.py Outdated Show resolved Hide resolved
algoliasearch/answers_client.py Outdated Show resolved Hide resolved
algoliasearch/answers_client.py Outdated Show resolved Hide resolved
algoliasearch/answers_client.py Outdated Show resolved Hide resolved
algoliasearch/configs.py Outdated Show resolved Hide resolved
algoliasearch/configs.py Outdated Show resolved Hide resolved
@PLNech PLNech requested a review from TomKlotzPro June 16, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomKlotzPro TomKlotzPro Awaiting requested review from TomKlotzPro

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PLNech @TomKlotzPro